Skip to content

Conversation

@Generalwin
Copy link
Collaborator

@Generalwin Generalwin commented Jan 9, 2026

Summary

  • What is changing and why?
  1. Pool-Based Sandbox Creation
    Support creating sandboxes from existing resource pools via poolRef in extensions field
    When poolRef is provided, the system uses pre-warmed pods from the pool instead of creating new ones
    Only entrypoint and env can be customized in pool mode; image and resources are predefined by the pool
  2. Dynamic Environment Variable Injection
    Implemented taskTemplate generation that dynamically injects environment variables
    Environment variables are written to .env file at runtime using shell commands
    User process runs in background mode to keep container alive

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Generalwin Generalwin force-pushed the k8s-pool branch 2 times, most recently from 2677a3a to 7f0d3a5 Compare January 12, 2026 06:47
@Generalwin Generalwin marked this pull request as ready for review January 12, 2026 06:50
@kevinlynx
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link

To use Codex here, create a Codex account and connect to github.

@jwx0925
Copy link
Collaborator

jwx0925 commented Jan 12, 2026

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f0d3a5280

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pangjiping
Pangjiping previously approved these changes Jan 14, 2026
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pangjiping Pangjiping merged commit 5348660 into alibaba:main Jan 15, 2026
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants